Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.cc

Issue 189443010: Mac AVFoundation/QTKit: delay DeviceMonitorMac startup to first GetUserMedia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_manager.cc
diff --git a/content/browser/renderer_host/media/media_stream_manager.cc b/content/browser/renderer_host/media/media_stream_manager.cc
index 14c0d4dc4675bb96ae83d0b79c0eb23a82f6ca30..77cb892a16d1d676e80624798ce6bb35d24f6c07 100644
--- a/content/browser/renderer_host/media/media_stream_manager.cc
+++ b/content/browser/renderer_host/media/media_stream_manager.cc
@@ -16,6 +16,7 @@
#include "base/strings/stringprintf.h"
#include "base/threading/thread.h"
#include "content/browser/browser_main_loop.h"
+#include "content/browser/device_monitor_mac.h"
#include "content/browser/media/capture/web_contents_capture_util.h"
#include "content/browser/renderer_host/media/audio_input_device_manager.h"
#include "content/browser/renderer_host/media/device_request_message_filter.h"
@@ -784,8 +785,27 @@ void MediaStreamManager::StartMonitoring() {
audio_input_device_manager_->EnumerateDevices(MEDIA_DEVICE_AUDIO_CAPTURE);
++active_enumeration_ref_count_[MEDIA_DEVICE_VIDEO_CAPTURE];
video_capture_manager_->EnumerateDevices(MEDIA_DEVICE_VIDEO_CAPTURE);
+
+#if defined(OS_MACOSX)
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&MediaStreamManager::StartMonitoringOnUIThread,
+ base::Unretained(this)));
+#endif
}
+#if defined(OS_MACOSX)
+void MediaStreamManager::StartMonitoringOnUIThread() {
Robert Sesek 2014/03/10 17:22:46 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::U
mcasas 2014/03/10 18:19:45 Done.
+ if (content::BrowserMainLoop::GetInstance()) {
+ BrowserThread::PostTask(
Robert Sesek 2014/03/10 17:22:46 Why do you need to post a task to do this?
mcasas 2014/03/10 18:19:45 Not needed now with the accessor device_monitor_ma
+ BrowserThread::UI,
+ FROM_HERE,
+ base::Bind(&BrowserMainLoop::StartMonitoring,
+ base::Unretained(content::BrowserMainLoop::GetInstance())));
+ }
+}
+#endif
+
void MediaStreamManager::StopMonitoring() {
DCHECK_EQ(base::MessageLoop::current(), io_loop_);
if (monitoring_started_) {

Powered by Google App Engine
This is Rietveld 408576698