chrome/browser/policy/cloud/user_policy_signin_service_factory.h - Issue 189443008: Use TestingProfile::Builder::AddTestingFactory at ChromeRenderViewHostTestHarness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/user_policy_signin_service_factory.h

Issue 189443008: Use TestingProfile::Builder::AddTestingFactory at ChromeRenderViewHostTestHarness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/policy/cloud/user_policy_signin_service_factory.cc » ('j') | chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/user_policy_signin_service_factory.h

diff --git a/chrome/browser/policy/cloud/user_policy_signin_service_factory.h b/chrome/browser/policy/cloud/user_policy_signin_service_factory.h

index 6042ea0022def6601bf7e56aa7476a3ebb43802a..8744fe0113c40f59e5e8b471b45d6d7d01b4504f 100644

--- a/chrome/browser/policy/cloud/user_policy_signin_service_factory.h

+++ b/chrome/browser/policy/cloud/user_policy_signin_service_factory.h

@@ -45,6 +45,9 @@ class UserPolicySigninServiceFactory

// Overridden to cause this object to be created when the profile is created.

virtual bool ServiceIsCreatedWithBrowserContext() const OVERRIDE;

+ // Don't create this service for tests.

+ virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;

Andrew T Wilson (Slow) 2014/03/10 12:30:45 I'm fundamentally opposed to this change - we shou

// Register the preferences related to cloud-based user policy.

virtual void RegisterProfilePrefs(

user_prefs::PrefRegistrySyncable* registry) OVERRIDE;