Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1894403002: datastore: Fix AddIndexes with existing namespaces (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

datastore: Fix AddIndexes with existing namespaces AddIndexes previously only added an index for the current namespace. Since indexes are global, they should be added for all existing namespaces. BUG= Committed: https://github.com/luci/gae/commit/19330b312aff818c8e78b36c597d5a4b63a9904c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -31 lines) Patch
M impl/memory/datastore.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_data.go View 5 chunks +33 lines, -3 lines 0 comments Download
M impl/memory/datastore_index.go View 2 chunks +16 lines, -14 lines 0 comments Download
M impl/memory/datastore_query_execution.go View 4 chunks +1 line, -12 lines 0 comments Download
M impl/memory/datastore_test.go View 3 chunks +54 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL, this should fix the AddIndexes bug.
4 years, 8 months ago (2016-04-19 06:46:41 UTC) #2
iannucci
lgtm
4 years, 8 months ago (2016-04-20 01:28:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894403002/1
4 years, 8 months ago (2016-04-20 15:33:34 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 15:38:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/19330b312aff818c8e78b36c597d5a4b63a9904c

Powered by Google App Engine
This is Rietveld 408576698