ui/views/view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/view.cc

diff --git a/ui/views/view.cc b/ui/views/view.cc

index 3d97f6b9748913a70dd03103f57e6d0b6ac32b43..39f6e55fc45b9cc3c8d05ce46c215e756cfd380a 100644

--- a/ui/views/view.cc

+++ b/ui/views/view.cc

@@ -1236,7 +1236,7 @@ const FocusManager* View::GetFocusManager() const {

void View::RequestFocus() {

FocusManager* focus_manager = GetFocusManager();

- if (focus_manager && IsFocusable())

+ if (focus_manager && IsAccessibilityFocusable())

karandeepb 2016/04/20 04:08:59 @sky- Can you confirm whether this is ok to do?

focus_manager->SetFocusedView(this);

}

« no previous file with comments | « ui/views/view.h ('k') | ui/views/window/dialog_client_view.cc » ('j') | no next file with comments »