ui/views/controls/textfield/textfield.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 1457a420da193789ed7d88d390a757d665382ef8..1a1da81c2362b179f69af035c17f5428cb729e54 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -293,6 +293,9 @@ Textfield::Textfield()

set_drag_controller(this);

GetRenderText()->SetFontList(GetDefaultFontList());

SetBorder(std::unique_ptr<Border>(new FocusableBorder()));

+ // On Mac, only textfields and list controls are focusable by default. Hence

+ // use ALWAYS focus behavior.

SetFocusBehavior(FocusBehavior::ALWAYS);

if (ViewsDelegate::GetInstance()) {

« no previous file with comments | « ui/views/controls/table/table_view.cc ('k') | ui/views/controls/tree/tree_view.cc » ('j') | ui/views/view.cc » ('J')