ui/views/window/dialog_client_view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/window/dialog_client_view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Address review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/window/dialog_client_view.cc

diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc

index e93e980ae472b1918ce4d05f03faf54ad2d674e1..62638feeb3c752c67daaa3d3da07dd97f5d09ab9 100644

--- a/ui/views/window/dialog_client_view.cc

+++ b/ui/views/window/dialog_client_view.cc

@@ -313,7 +313,7 @@ LabelButton* DialogClientView::CreateDialogButton(ui::DialogButton type) {

button = new LabelButton(this, title);

button->SetStyle(Button::STYLE_BUTTON);

}

- button->SetFocusBehavior(FocusBehavior::ALWAYS);

+ Button::ConfigureDefaultFocus(button);

const int kDialogMinButtonWidth = 75;

button->SetMinSize(gfx::Size(kDialogMinButtonWidth, 0));

« ui/views/test/views_test_helper_mac.h ('K') | « ui/views/widget/native_widget_mac_unittest.mm ('k') | no next file » | no next file with comments »