chrome/browser/ui/views/location_bar/location_icon_view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Address review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_view.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc » ('j') | ui/views/focus/focus_traversal_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc

index b185b8e9f30c1f9be60317bb2228a53b2393ccb8..4392be08fab55a5831190a1132ecb1d894e8863c 100644

--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc

@@ -35,7 +35,13 @@ LocationIconView::LocationIconView(const gfx::FontList& font_list,

suppress_mouse_released_action_(false),

location_bar_(location_bar) {

set_id(VIEW_ID_LOCATION_ICON);

+#if defined(OS_MACOSX)

+ SetFocusBehavior(FocusBehavior::ACCESSIBLE_ONLY);

+#else

SetFocusBehavior(FocusBehavior::ALWAYS);

+#endif

SetBackground(false);

}