ui/views/view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Unified Diff: ui/views/view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Address review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/focus/focus_traversal_unittest.cc ('K') | « ui/views/touchui/touch_selection_menu_runner_views.cc ('k') | ui/views/widget/native_widget_mac_unittest.mm » ('j') | ui/views/widget/native_widget_mac_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/view.cc

diff --git a/ui/views/view.cc b/ui/views/view.cc

index 8127f797aebbc81ba1f44621b5a15876f599154e..0e733ad6a898f01863c3eccbda30c5de2bc15237 100644

--- a/ui/views/view.cc

+++ b/ui/views/view.cc

@@ -1226,7 +1226,7 @@ const FocusManager* View::GetFocusManager() const {

void View::RequestFocus() {

FocusManager* focus_manager = GetFocusManager();

- if (focus_manager && IsFocusable())

+ if (focus_manager && IsAccessibilityFocusable())

karandeepb 2016/05/03 02:54:13 Does this seem fine to you or should we do this on

tapted 2016/05/03 08:08:26 Isn't this needed to support the change to FocusMa

karandeepb 2016/05/04 01:56:38 Not really. This is needed on Mac, since if we do

tapted 2016/05/04 06:47:38 Acknowledged. I think this is fine to have on all

focus_manager->SetFocusedView(this);

}