chrome/browser/ui/views/toolbar/app_menu.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Address review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc ('k') | chrome/browser/ui/views/website_settings/chosen_object_view.cc » ('j') | ui/base/test/scoped_fake_full_keyboard_access.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/app_menu.cc

diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc

index 8e753d99a293d6c28163afd1bd20f6350bfa68ac..6e6adf43ffe437f70b2fd8ee90c22de62465116f 100644

--- a/chrome/browser/ui/views/toolbar/app_menu.cc

+++ b/chrome/browser/ui/views/toolbar/app_menu.cc

@@ -284,6 +284,8 @@ class InMenuButton : public LabelButton {

~InMenuButton() override {}

void Init(InMenuButtonBackground::ButtonType type) {

+ // An InMenuButton should always be focusable regardless of the platform.

+ // Hence we don't use Button::ConfigureDefaultFocus().

SetFocusBehavior(FocusBehavior::ALWAYS);

set_request_focus_on_press(false);

SetHorizontalAlignment(gfx::ALIGN_CENTER);

@@ -553,6 +555,8 @@ class AppMenu::ZoomView : public AppMenuView {

IDR_FULLSCREEN_MENU_BUTTON);

fullscreen_button_->SetImage(ImageButton::STATE_NORMAL, full_screen_image);

+ // Since |fullscreen_button_| will reside in a menu, make it ALWAYS

+ // focusable regardless of the platform.

fullscreen_button_->SetFocusBehavior(FocusBehavior::ALWAYS);

fullscreen_button_->set_request_focus_on_press(false);

fullscreen_button_->set_tag(fullscreen_index);