third_party/WebKit/Source/web/WebInputEventConversion.cpp - Issue 1894363004: Articulate the cancel behavior in WebMouseWheelEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebInputEventConversion.cpp

Issue 1894363004: Articulate the cancel behavior in WebMouseWheelEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_all_passive

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/WheelEvent.h ('K') | « third_party/WebKit/Source/web/WebInputEvent.cpp ('k') | third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp » ('j') | third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebInputEventConversion.cpp

diff --git a/third_party/WebKit/Source/web/WebInputEventConversion.cpp b/third_party/WebKit/Source/web/WebInputEventConversion.cpp

index fd00ac28660de1ae5fdc5907742cd7b7652f8881..c25a7b362a72945f38b5ff2a7a35c73dd14210e7 100644

--- a/third_party/WebKit/Source/web/WebInputEventConversion.cpp

+++ b/third_party/WebKit/Source/web/WebInputEventConversion.cpp

@@ -211,6 +211,7 @@ PlatformWheelEventBuilder::PlatformWheelEventBuilder(Widget* widget, const WebMo

m_timestamp = e.timeStampSeconds;

m_modifiers = e.modifiers;

+ m_dispatchType = toPlatformDispatchType(e.dispatchType);

m_hasPreciseScrollingDeltas = e.hasPreciseScrollingDeltas;

m_canScroll = e.canScroll;

@@ -621,6 +622,7 @@ WebMouseWheelEventBuilder::WebMouseWheelEventBuilder(const Widget* widget, const

resendingPluginId = event.resendingPluginId();

railsMode = static_cast<RailsMode>(event.getRailsMode());

hasPreciseScrollingDeltas = event.hasPreciseScrollingDeltas();

+ dispatchType = event.cancelable() ? WebInputEvent::Blocking : WebInputEvent::EventNonBlocking;

}

WebKeyboardEventBuilder::WebKeyboardEventBuilder(const KeyboardEvent& event)