Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: third_party/WebKit/Source/core/events/WheelEvent.h

Issue 1894363004: Articulate the cancel behavior in WebMouseWheelEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_all_passive
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/WheelEvent.h
diff --git a/third_party/WebKit/Source/core/events/WheelEvent.h b/third_party/WebKit/Source/core/events/WheelEvent.h
index a3ec83443e1212f9078826428e20e7bb09b481af..bb2491dcc4e681404143b215addb035a5a71eafe 100644
--- a/third_party/WebKit/Source/core/events/WheelEvent.h
+++ b/third_party/WebKit/Source/core/events/WheelEvent.h
@@ -61,11 +61,11 @@ public:
const FloatPoint& rawDelta, unsigned deltaMode, AbstractView* view,
const IntPoint& screenLocation, const IntPoint& windowLocation,
PlatformEvent::Modifiers modifiers, unsigned short buttons, double platformTimeStamp,
- bool canScroll, int resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode railsMode)
+ bool canScroll, int resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode railsMode, bool cancelable)
tdresser 2016/04/20 13:20:10 Should the final parameter be a two-valued enum, f
dtapuska 2016/04/20 14:03:04 I don't disagree with this but the rest of the cod
tdresser 2016/04/20 14:53:25 SGTM.
{
return new WheelEvent(wheelTicks, rawDelta, deltaMode, view,
screenLocation, windowLocation, modifiers, buttons, platformTimeStamp,
- canScroll, resendingPluginId, hasPreciseScrollingDeltas, railsMode);
+ canScroll, resendingPluginId, hasPreciseScrollingDeltas, railsMode, cancelable);
}
double deltaX() const { return m_deltaX; } // Positive when scrolling right.
@@ -96,7 +96,7 @@ private:
WheelEvent(const FloatPoint& wheelTicks, const FloatPoint& rawDelta,
unsigned, AbstractView*, const IntPoint& screenLocation, const IntPoint& windowLocation,
PlatformEvent::Modifiers, unsigned short buttons, double platformTimeStamp,
- bool canScroll, int resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode);
+ bool canScroll, int resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode, bool cancelable);
IntPoint m_wheelDelta;
double m_deltaX;

Powered by Google App Engine
This is Rietveld 408576698