Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2354)

Unified Diff: content/renderer/render_widget.cc

Issue 1894333002: Make WebWidget::resize early out if the size doesn't change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_widget_fullscreen_pepper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 5f7490d632fbad1b22c19e3d97d26b24428ed836..08d572b6e6b8eeca1cc24fe628da67457b757e6e 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -677,6 +677,8 @@ void RenderWidget::OnWasShown(bool needs_repainting,
void RenderWidget::OnRequestMoveAck() {
DCHECK(pending_window_rect_count_);
pending_window_rect_count_--;
+ if (!pending_window_rect_count_)
+ view_screen_rect_ = pending_window_rect_;
}
GURL RenderWidget::GetURLForGraphicsContext3D() {
@@ -1134,9 +1136,6 @@ void RenderWidget::Resize(const ResizeParams& params) {
if (compositor_)
compositor_->setViewportSize(params.physical_backing_size);
- bool resized = size_ != params.new_size ||
- physical_backing_size_ != params.physical_backing_size;
-
size_ = params.new_size;
physical_backing_size_ = params.physical_backing_size;
@@ -1154,17 +1153,16 @@ void RenderWidget::Resize(const ResizeParams& params) {
webwidget_->setTopControlsHeight(params.top_controls_height,
top_controls_shrink_blink_size_);
- if (resized) {
- gfx::Size new_widget_size = size_;
- if (IsUseZoomForDSFEnabled()) {
- new_widget_size = gfx::ScaleToCeiledSize(new_widget_size,
- GetOriginalDeviceScaleFactor());
- }
- // When resizing, we want to wait to paint before ACK'ing the resize. This
- // ensures that we only resize as fast as we can paint. We only need to
- // send an ACK if we are resized to a non-empty rect.
- webwidget_->resize(new_widget_size);
+ gfx::Size new_widget_size = size_;
+ if (IsUseZoomForDSFEnabled()) {
+ new_widget_size = gfx::ScaleToCeiledSize(new_widget_size,
+ GetOriginalDeviceScaleFactor());
}
+ // When resizing, we want to wait to paint before ACK'ing the resize. This
+ // ensures that we only resize as fast as we can paint. We only need to
+ // send an ACK if we are resized to a non-empty rect.
+ webwidget_->resize(new_widget_size);
+
WebSize visual_viewport_size;
if (IsUseZoomForDSFEnabled()) {
« no previous file with comments | « no previous file | content/renderer/render_widget_fullscreen_pepper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698