Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 189433004: Enable more webrtc content_browsertests on Android. (Closed)

Created:
6 years, 9 months ago by wjia(left Chromium)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Enable more webrtc content_browsertests on Android. Fix SDP filtering issue on Android. rtpmap 101 is a data codec and it shouldn't be removed. Some tests are fixed by this patch: WebRtcBrowserTest.CanSetupLegacyCall WebRtcBrowserTest.CallWithDataOnly WebRtcBrowserTest.CallWithDataAndMedia WebRtcAecDumpBrowserTest.CallWithAecDump Some tests have been disabled in the source code: WebRtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiate WebRtcBrowserTest.CallWithDataAndLaterAddMedia WebRTCInternalsBrowserTest.WithRealPeerConnectionCall Some tests are no longer there: WebRTCInternalsBrowserTest.NegotiateUnsupportedVideoCodec WebRTCInternalsBrowserTest.NegotiateNonCryptoCall BUG=181069 R=ronghuawu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +0 lines, -11 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ronghua Wu (Left Chromium)
lgtm Excellent.
6 years, 9 months ago (2014-03-07 19:19:43 UTC) #1
wjia(left Chromium)
6 years, 9 months ago (2014-03-07 19:21:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r255679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698