Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 189433003: Remove --background-color-instead-of-checkerboard flag. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, piman
Visibility:
Public.

Description

Remove --background-color-instead-of-checkerboard flag. This is now unused on all platforms. R=aelias BUG=350142 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255752

Patch Set 1 #

Patch Set 2 : backgroundcolorinsteadofcheckerboard: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -23 lines) Patch
M cc/base/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/layers/layer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
danakj
6 years, 9 months ago (2014-03-06 23:32:02 UTC) #1
danakj
I don't know where clank sets this flag. Is it not used anymore? Should it ...
6 years, 9 months ago (2014-03-06 23:33:34 UTC) #2
aelias_OOO_until_Jul13
On 2014/03/06 23:33:34, danakj wrote: > I don't know where clank sets this flag. Is ...
6 years, 9 months ago (2014-03-06 23:44:29 UTC) #3
danakj
OK PTAL
6 years, 9 months ago (2014-03-06 23:59:16 UTC) #4
aelias_OOO_until_Jul13
lgtm
6 years, 9 months ago (2014-03-07 00:01:18 UTC) #5
danakj
+piman for OWNERS
6 years, 9 months ago (2014-03-07 00:01:40 UTC) #6
danakj
piman PTAL :)
6 years, 9 months ago (2014-03-07 16:26:09 UTC) #7
piman
lgtm
6 years, 9 months ago (2014-03-07 17:42:27 UTC) #8
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-07 17:50:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189433003/20001
6 years, 9 months ago (2014-03-07 17:51:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189433003/20001
6 years, 9 months ago (2014-03-07 20:19:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189433003/20001
6 years, 9 months ago (2014-03-08 10:48:30 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 11:35:12 UTC) #13
Message was sent while issue was closed.
Change committed as 255752

Powered by Google App Engine
This is Rietveld 408576698