Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1894273002: Fix chrome crashing in mash_session. (Closed)

Created:
4 years, 8 months ago by kylechar
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome crashing in mash_session. The chrome browser process would crash upon starting in mash_session. This resulted from the MojoShellConnection being initialized after it was used for the first time. Move the initialization of MojoShellConnection to immediately before it's first used to fix crash. BUG=604443 Committed: https://crrev.com/2117bf3be12fc1a4ef2be40d3d6c28804917759a Cr-Commit-Position: refs/heads/master@{#388243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M content/browser/browser_main_loop.cc View 3 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-19 00:10:58 UTC) #2
Ken Rockot(use gerrit already)
also +sky FYI
4 years, 8 months ago (2016-04-19 00:11:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894273002/1
4 years, 8 months ago (2016-04-19 12:43:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/170254)
4 years, 8 months ago (2016-04-19 12:50:41 UTC) #7
kylechar
+jam as reviewer from OWNERS.
4 years, 8 months ago (2016-04-19 12:55:59 UTC) #9
jam
lgtm
4 years, 8 months ago (2016-04-19 17:59:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894273002/1
4 years, 8 months ago (2016-04-19 18:00:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 18:05:49 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2117bf3be12fc1a4ef2be40d3d6c28804917759a
Cr-Commit-Position: refs/heads/master@{#388243}

Powered by Google App Engine
This is Rietveld 408576698