Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1894263002: [Debugger] Fix StepNext over function with caught exception (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Debugger] Fix StepNext over function with caught exception Without CL debugger on StepNext adds breakpoint to function where throw instruction is located. In case of StepNext we will skip pause in this function because StepNext shouldn't break in a deeper frame. BUG=chromium:604495 R=yangguo@chromium.org LOG=N Committed: https://crrev.com/de5aaad638b7769457c50737cef50423b9bd0d6e Cr-Commit-Position: refs/heads/master@{#35627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M src/debug/debug.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Yang, please take a look.
4 years, 8 months ago (2016-04-18 21:44:50 UTC) #1
Yang
On 2016/04/18 21:44:50, kozyatinskiy wrote: > Yang, please take a look. LGTM. Thanks!
4 years, 8 months ago (2016-04-19 14:38:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894263002/1
4 years, 8 months ago (2016-04-19 15:06:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 15:28:56 UTC) #5
nodir1
4 years, 8 months ago (2016-04-22 18:43:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de5aaad638b7769457c50737cef50423b9bd0d6e
Cr-Commit-Position: refs/heads/master@{#35627}

Powered by Google App Engine
This is Rietveld 408576698