Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/events/MouseEvent.cpp

Issue 1894253002: Prevent sending click event for non primary button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/MouseEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/MouseEvent.cpp b/third_party/WebKit/Source/core/events/MouseEvent.cpp
index 943a33e71c2d3d2797810a8027c2d55900541b6d..c34468cf0de173777e20df983294f52ef70d57e5 100644
--- a/third_party/WebKit/Source/core/events/MouseEvent.cpp
+++ b/third_party/WebKit/Source/core/events/MouseEvent.cpp
@@ -294,6 +294,10 @@ DispatchEventResult MouseEventDispatchMediator::dispatchEvent(EventDispatcher& d
if (mouseEvent.type() != EventTypeNames::click || mouseEvent.detail() != 2)
return dispatchResult;
+ // Do not send dblclick event for middle click
+ if (mouseEvent.button() == MouseButton::MiddleButton)
dtapuska 2016/04/22 18:32:30 I don't think this is what the spec indicates. It
Navid Zolghadr 2016/04/22 19:09:58 Right. So much focusing on middlebutton that I for
+ return dispatchResult;
+
// Special case: If it's a double click event, we also send the dblclick event. This is not part
// of the DOM specs, but is used for compatibility with the ondblclick="" attribute. This is treated
// as a separate event in other DOM-compliant browsers like Firefox, and so we do the same.

Powered by Google App Engine
This is Rietveld 408576698