Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1894243002: PDF: Split pdf/DEPS into pdf/pdfium/DEPS (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Split pdf/DEPS into pdf/pdfium/DEPS TBR=danakj@chromium.org,jochen@chromium.org Committed: https://crrev.com/8d505a3c22080cdff3b70edcfa96846e9788d313 Cr-Commit-Position: refs/heads/master@{#388075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M pdf/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
A pdf/pdfium/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Lei Zhang
Just narrowing the scope a bit.
4 years, 8 months ago (2016-04-18 22:58:20 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-18 23:11:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894243002/1
4 years, 8 months ago (2016-04-18 23:15:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/170087)
4 years, 8 months ago (2016-04-18 23:25:13 UTC) #7
Lei Zhang
TBR jochen and danakj since there's no new dependencies and I'm just shuffling things around.
4 years, 8 months ago (2016-04-18 23:26:50 UTC) #9
Lei Zhang
On 2016/04/18 23:26:50, Lei Zhang wrote: > TBR jochen and danakj since there's no new ...
4 years, 8 months ago (2016-04-18 23:27:39 UTC) #11
danakj
LGTM
4 years, 8 months ago (2016-04-18 23:27:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894243002/1
4 years, 8 months ago (2016-04-18 23:28:11 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:33:05 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:35:24 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8d505a3c22080cdff3b70edcfa96846e9788d313
Cr-Commit-Position: refs/heads/master@{#388075}

Powered by Google App Engine
This is Rietveld 408576698