Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1894203002: Fix polymorphic keyed load handler selection for proxies. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix polymorphic keyed load handler selection for proxies. BUG=chromium:603463 LOG=N Committed: https://crrev.com/28113880e317acdb374372b6dac101a46458fa46 Cr-Commit-Position: refs/heads/master@{#35607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M src/ic/ic.cc View 2 chunks +9 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-603463.js View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894203002/1
4 years, 8 months ago (2016-04-18 18:11:17 UTC) #2
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-18 18:15:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 18:32:50 UTC) #6
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-19 08:53:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894203002/1
4 years, 8 months ago (2016-04-19 08:55:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 08:57:01 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 08:58:54 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/28113880e317acdb374372b6dac101a46458fa46
Cr-Commit-Position: refs/heads/master@{#35607}

Powered by Google App Engine
This is Rietveld 408576698