Remove RenderFrameHostManager::MoveToPendingDeleteHosts

Remove RenderFrameHostManager::MoveToPendingDeleteHosts

This method is only called twice in one method after some code clean up
has happened. It seems we don't need a full method for that at this point.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e696e47994432cc1075f3fb74de7c7e9ac2b29a4
Cr-Commit-Position: refs/heads/master@{#388081}

[nasko, 2016-04-18 16:35:32]

Description was changed from

==========
Remove RenderFrameHostManager::MoveToPendingDeleteHosts

This method is only called twice in one method after some code clean up
has happened. It seems we don't need a full method for that at this point.

BUG=357747
==========

to

==========
Remove RenderFrameHostManager::MoveToPendingDeleteHosts

This method is only called twice in one method after some code clean up
has happened. It seems we don't need a full method for that at this point.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-04-18 16:37:05]

nasko@chromium.org changed reviewers:
+ alexmos@chromium.org

[nasko, 2016-04-18 16:37:05]

Hey Alex,
I think we don't need RFHM::MoveToPendingDeleteHosts anymore and this is a CL to
remove it. Can you review it for me?
Thanks in advance!
Nasko

[alexmos, 2016-04-18 20:48:06]

LGTM

https://codereview.chromium.org/1894193002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/1894193002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:678:
pending_delete_hosts_.push_back(std::move(old_render_frame_host));
nit: instead of repeating the comment, I'm curious if we could just add an else
clause to the active_frame_count if statement, and push the proxy work there,
and then only do the pending_delete_hosts.push_back once, here.  I think it's
fine either way though.

[nasko, 2016-04-18 22:00:16]

https://codereview.chromium.org/1894193002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/1894193002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:678:
pending_delete_hosts_.push_back(std::move(old_render_frame_host));
On 2016/04/18 20:48:05, alexmos wrote:
> nit: instead of repeating the comment, I'm curious if we could just add an
else
> clause to the active_frame_count if statement, and push the proxy work there,
> and then only do the pending_delete_hosts.push_back once, here.  I think it's
> fine either way though.

Good idea! Done.

[nasko, 2016-04-18 22:00:22]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 22:00:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894193002/20001

[alexmos, 2016-04-18 23:13:24]

LGTM

[nasko, 2016-04-18 23:14:31]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2016-04-18 23:14:46]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-04-18 23:15:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894193002/20001

[commit-bot: I haz the power, 2016-04-18 23:46:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-18 23:47:57]

Description was changed from

==========
Remove RenderFrameHostManager::MoveToPendingDeleteHosts

This method is only called twice in one method after some code clean up
has happened. It seems we don't need a full method for that at this point.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove RenderFrameHostManager::MoveToPendingDeleteHosts

This method is only called twice in one method after some code clean up
has happened. It seems we don't need a full method for that at this point.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e696e47994432cc1075f3fb74de7c7e9ac2b29a4
Cr-Commit-Position: refs/heads/master@{#388081}
==========

[commit-bot: I haz the power, 2016-04-18 23:47:58]

Patchset 2 (id:??) landed as
https://crrev.com/e696e47994432cc1075f3fb74de7c7e9ac2b29a4
Cr-Commit-Position: refs/heads/master@{#388081}