Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1894173004: Revert of cc: Stop locking the raster scale factor at 1 after any change. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
3 years, 7 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chrishtr, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Stop locking the raster scale factor at 1 after any change. (patchset #1 id:1 of https://codereview.chromium.org/1474853002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=600482 Original issue's description: > cc: Stop locking the raster scale factor at 1 after any change. > > Currently if the PictureLayerImpl's transform scale changes ever > outside of a CSS animation, we lock the raster scale to 1 to prevent > any re-raster work from happening. > > This leads to really inconsistent/buggy/unpredictable behaviour for > web developers. Sometimes this only becomes visible after switching > tabs and back, causing the old tiling to be evicted. > > This optimization was added when CSS animations were very new to the > web, now they are more common and we should expect developers to use > CSS animations if they want to change the scale of an element frequently > as this provides the needed hints to the compositor about how to raster > the content. We cargo-culted this into the impl-side painting > implementation and tweaked it from there. > > This patch removes the hueristic entirely around fixing the raster scale, > meaning that we'll always raster at the scale javascript provides on the > layer. This eliminates many "things are blurry" problems from the web > (see bugs 556533, 413636, 368201, and 542166 for some examples). > > R=enne, vmpstr > BUG=556533 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/66978ff65abbb473f8662444c2dc0823e0f45795 > Cr-Commit-Position: refs/heads/master@{#361551} TBR=enne@chromium.org,vmpstr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=556533, 600482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -101 lines) Patch
M cc/layers/picture_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 5 chunks +26 lines, -4 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 5 chunks +64 lines, -97 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
danakj
Created Revert of cc: Stop locking the raster scale factor at 1 after any change.
4 years, 8 months ago (2016-04-19 23:38:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894173004/1
4 years, 8 months ago (2016-04-19 23:38:53 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 00:24:43 UTC) #7
Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698