Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1894173002: Convert LinkDisambiguationPopup to BubbleDialogDelegateView (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
msw, ananta, luken
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LinkDisambiguationPopup to BubbleDialogDelegateView BUG=585312 Committed: https://crrev.com/34488c009ae05b9fe28ab8cae70303b73a14e1a5 Cr-Commit-Position: refs/heads/master@{#388597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc View 9 chunks +19 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Evan Stade
+luken, do you have any tips for how to test this? I can't seem to ...
4 years, 8 months ago (2016-04-18 15:57:41 UTC) #2
msw
lgtm
4 years, 8 months ago (2016-04-18 20:27:01 UTC) #3
Evan Stade
+ananta, do you know how to test this? do I need a windows machine?
4 years, 8 months ago (2016-04-19 14:11:21 UTC) #5
Evan Stade
This is a pretty mechanical change and the bubble is disabled (except with a command ...
4 years, 8 months ago (2016-04-19 17:12:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894173002/1
4 years, 8 months ago (2016-04-20 21:54:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 23:51:17 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:27:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34488c009ae05b9fe28ab8cae70303b73a14e1a5
Cr-Commit-Position: refs/heads/master@{#388597}

Powered by Google App Engine
This is Rietveld 408576698