chrome/browser/about_flags.cc - Issue 1894143002: Delete the NotificationActionIcons flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 1894143002: Delete the NotificationActionIcons flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index c38fad4656cda7ba43b59e397139cc62f59e2ee3..801d66030ba743a5f73a9882e853f9e8a0fb7b3b 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1191,12 +1191,6 @@ const FeatureEntry kFeatureEntries[] = {

IDS_NOTIFICATIONS_NATIVE_FLAG_DESCRIPTION, kOsMac,

SINGLE_VALUE_TYPE(switches::kEnableNativeNotifications)},

#endif

-#if defined(ENABLE_NOTIFICATIONS)

- {"enable-notification-action-icons",

- IDS_FLAGS_ENABLE_NOTIFICATION_ACTION_ICONS_NAME,

johnme 2016/04/18 18:04:06 Please remove both strings from chrome/app/generat

Michael van Ouwerkerk 2016/04/19 09:25:14 Done.

- IDS_FLAGS_ENABLE_NOTIFICATION_ACTION_ICONS_DESCRIPTION, kOsAll,

- SINGLE_VALUE_TYPE(switches::kEnableNotificationActionIcons)},

-#endif

#if defined(TOOLKIT_VIEWS)

{"disable-views-rect-based-targeting", // FLAGS:RECORD_UMA

IDS_FLAGS_VIEWS_RECT_BASED_TARGETING_NAME,