Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1894143002: Delete the NotificationActionIcons flag. (Closed)

Created:
4 years, 8 months ago by Michael van Ouwerkerk
Modified:
4 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the NotificationActionIcons flag. This feature shipped in M50: http://blog.chromium.org/2016/03/chrome-50-beta-push-notification.html BUG=581336 TBR=mkwst,avi Committed: https://crrev.com/876c529f700d91c9c3f30704362ea8876a35f5a9 Cr-Commit-Position: refs/heads/master@{#388190}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address johnme's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationAction.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894143002/1
4 years, 8 months ago (2016-04-18 14:18:31 UTC) #2
Michael van Ouwerkerk
John, could you take a look please?
4 years, 8 months ago (2016-04-18 14:47:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 16:06:09 UTC) #6
johnme
lgtm once comments are addressed https://codereview.chromium.org/1894143002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/1894143002/diff/1/chrome/browser/about_flags.cc#oldcode1196 chrome/browser/about_flags.cc:1196: IDS_FLAGS_ENABLE_NOTIFICATION_ACTION_ICONS_NAME, Please remove both ...
4 years, 8 months ago (2016-04-18 18:04:06 UTC) #7
Michael van Ouwerkerk
Thanks John! https://codereview.chromium.org/1894143002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/1894143002/diff/1/chrome/browser/about_flags.cc#oldcode1196 chrome/browser/about_flags.cc:1196: IDS_FLAGS_ENABLE_NOTIFICATION_ACTION_ICONS_NAME, On 2016/04/18 18:04:06, johnme wrote: > ...
4 years, 8 months ago (2016-04-19 09:25:14 UTC) #8
Michael van Ouwerkerk
TBR mwkst for WebKit cleanups TBR avi for content cleanups
4 years, 8 months ago (2016-04-19 09:35:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894143002/20001
4 years, 8 months ago (2016-04-19 09:35:39 UTC) #14
haraken
LGTM
4 years, 8 months ago (2016-04-19 09:45:51 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 12:37:54 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/876c529f700d91c9c3f30704362ea8876a35f5a9 Cr-Commit-Position: refs/heads/master@{#388190}
4 years, 8 months ago (2016-04-19 12:39:16 UTC) #19
Avi (use Gerrit)
4 years, 8 months ago (2016-04-19 13:59:07 UTC) #20
Message was sent while issue was closed.
Flag be gone!!!

LGTM!!

Thank you!

Powered by Google App Engine
This is Rietveld 408576698