Send WorkerHostMsg_WorkerConnected in EmbeddedSharedWorkerStub::OnConnect.

Send WorkerHostMsg_WorkerConnected in EmbeddedSharedWorkerStub::OnConnect.

WorkerHostMsg_WorkerConnected must be sent in EmbeddedSharedWorkerStub::OnConnect if the SharedWorker is already running.
In current code the memory leak of SharedWorkerConnector could occur because SharedWorkerConnector::connected() is not called.

BUG=327256
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256432

[horo, 2014-03-10 12:14:42]

kinuko@
Please review this cl.
Thank you.

[kinuko, 2014-03-10 13:26:02]

lgtm

https://codereview.chromium.org/189413014/diff/1/content/renderer/shared_work...
File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right):

https://codereview.chromium.org/189413014/diff/1/content/renderer/shared_work...
content/renderer/shared_worker/embedded_shared_worker_stub.cc:146: route_id_));
Should we add ConnectToChannel() method which always does impl_->connect() and
Send(Connected) together?  (I'm fine with the current code too though)

[horo, 2014-03-11 01:01:00]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-03-11 01:04:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/horo@chromium.org/189413014/20001

[horo, 2014-03-11 01:14:12]

https://codereview.chromium.org/189413014/diff/1/content/renderer/shared_work...
File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right):

https://codereview.chromium.org/189413014/diff/1/content/renderer/shared_work...
content/renderer/shared_worker/embedded_shared_worker_stub.cc:146: route_id_));
On 2014/03/10 13:26:02, kinuko wrote:
> Should we add ConnectToChannel() method which always does impl_->connect() and
> Send(Connected) together?  (I'm fine with the current code too though)

Done.

[horo, 2014-03-11 01:14:12]

https://codereview.chromium.org/189413014/diff/1/content/renderer/shared_work...
File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right):

https://codereview.chromium.org/189413014/diff/1/content/renderer/shared_work...
content/renderer/shared_worker/embedded_shared_worker_stub.cc:146: route_id_));
On 2014/03/10 13:26:02, kinuko wrote:
> Should we add ConnectToChannel() method which always does impl_->connect() and
> Send(Connected) together?  (I'm fine with the current code too though)

Done.

[commit-bot: I haz the power, 2014-03-11 01:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 01:48:49]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[kinuko, 2014-03-11 02:33:29]

(still lgtm)

you'll need owner review as we don't seem to have OWNERS file in
content/renderer/shared_worker

[horo, 2014-03-11 03:34:59]

On 2014/03/11 02:33:29, kinuko wrote:
> (still lgtm)
> 
> you'll need owner review as we don't seem to have OWNERS file in
> content/renderer/shared_worker

I created CL of OWNERS file.
https://codereview.chromium.org/194063004/

[horo, 2014-03-11 23:42:43]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-03-11 23:48:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/horo@chromium.org/189413014/20001

[commit-bot: I haz the power, 2014-03-12 05:06:21]

Change committed as 256432