Issue 189413008: Move DeviceOrientation / DeviceMotion event handlers to device_orientation module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189413008: Move DeviceOrientation / DeviceMotion event handlers to device_orientation module (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
timvolodine, abarth-chromium

CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, arv+blink, Inactive, timvolodine, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move DeviceOrientation / DeviceMotion event handlers to device_orientation module Move DeviceOrientation / DeviceMotion event handlers to device_orientation module using partial IDL interfaces instead of editing Window.idl directly. This is more modular. R=abarth, timvolodine@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168787

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -13 lines)			Patch
M	Source/core/frame/DOMWindow.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/frame/Window.idl	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A	Source/modules/device_orientation/DOMWindowDeviceMotion.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	Source/modules/device_orientation/DOMWindowDeviceOrientation.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A +	Source/modules/device_orientation/WindowDeviceMotion.idl	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	Source/modules/device_orientation/WindowDeviceOrientation.idl	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/modules/modules.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/189413008/1

6 years, 9 months ago (2014-03-08 17:17:28 UTC) #4

Message was sent while issue was closed.

Change committed as 168787

Expand Messages | Collapse Messages