Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
189413007:
IndexedDB: Remove invalid DCHECK that database name is non-empty (Closed)
|
Created:
6 years, 9 months ago by jsbell Modified:
6 years, 9 months ago CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionIndexedDB: Remove invalid DCHECK that database name is non-empty
Nothing in the spec - or Blink implementation - precludes empty names
for databases. Remove this bogus DCHECK.
Will add Blink-side layout tests once this lands.
BUG=350133
R=cmumford
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255828
Patch Set 1 #
Messages
Total messages: 21 (0 generated)
cmumford@ - please take a look?
On 2014/03/07 22:00:50, jsbell wrote: > cmumford@ - please take a look? lgtm
The CQ bit was checked by jsbell@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/189413007/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/189413007/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/189413007/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/189413007/1
Message was sent while issue was closed.
Change committed as 255828 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
