Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1894113003: Only fire accessible load complete events on the main frame on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility_manager_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc
index 20599dc90586bd1141725740018226574f70a1d7..e6e26f89cc5104d490496a204d41f6e952899775 100644
--- a/content/browser/accessibility/browser_accessibility_manager_android.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc
@@ -217,6 +217,12 @@ void BrowserAccessibilityManagerAndroid::NotifyAccessibilityEvent(
return;
}
+ // Ignore load complete events on iframes.
+ if (event_type == ui::AX_EVENT_LOAD_COMPLETE &&
+ node->manager() != GetRootManager()) {
+ return;
+ }
+
// Always send AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED to notify
// the Android system that the accessibility hierarchy rooted at this
// node has changed.
David Tseng 2016/04/18 23:21:56 Do you still need to do this?
dmazzoni 2016/04/19 18:52:23 Yes, Peter says it's definitely needed for Braille
David Tseng 2016/04/19 20:36:30 I wasn't clear, sorry: in the case of a load compl
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698