Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 1894113003: Only fire accessible load complete events on the main frame on Android. (Closed)

Created:
4 years, 8 months ago by dmazzoni
Modified:
4 years, 8 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only fire accessible load complete events on the main frame on Android. BUG=604524 Committed: https://crrev.com/93972adf9120670ef5c6c42b609aeeeb4bc41ad4 Cr-Commit-Position: refs/heads/master@{#388896}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move load complete check after handleContentChanged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (5 generated)
dmazzoni
4 years, 8 months ago (2016-04-18 22:47:50 UTC) #3
David Tseng
https://codereview.chromium.org/1894113003/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc File content/browser/accessibility/browser_accessibility_manager_android.cc (left): https://codereview.chromium.org/1894113003/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc#oldcode222 content/browser/accessibility/browser_accessibility_manager_android.cc:222: // node has changed. Do you still need to ...
4 years, 8 months ago (2016-04-18 23:21:56 UTC) #4
dmazzoni
https://codereview.chromium.org/1894113003/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc File content/browser/accessibility/browser_accessibility_manager_android.cc (left): https://codereview.chromium.org/1894113003/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc#oldcode222 content/browser/accessibility/browser_accessibility_manager_android.cc:222: // node has changed. On 2016/04/18 23:21:56, David Tseng ...
4 years, 8 months ago (2016-04-19 18:52:23 UTC) #5
David Tseng
https://codereview.chromium.org/1894113003/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc File content/browser/accessibility/browser_accessibility_manager_android.cc (left): https://codereview.chromium.org/1894113003/diff/1/content/browser/accessibility/browser_accessibility_manager_android.cc#oldcode222 content/browser/accessibility/browser_accessibility_manager_android.cc:222: // node has changed. On 2016/04/19 18:52:23, dmazzoni wrote: ...
4 years, 8 months ago (2016-04-19 20:36:30 UTC) #6
dmazzoni
On 2016/04/19 20:36:30, David Tseng wrote: > I wasn't clear, sorry: in the case of ...
4 years, 8 months ago (2016-04-21 17:46:28 UTC) #7
David Tseng
lgtm
4 years, 8 months ago (2016-04-21 20:29:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894113003/20001
4 years, 8 months ago (2016-04-21 20:45:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 21:04:42 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:39:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93972adf9120670ef5c6c42b609aeeeb4bc41ad4
Cr-Commit-Position: refs/heads/master@{#388896}

Powered by Google App Engine
This is Rietveld 408576698