Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1894103003: Remove superfluous "*-expected.txt" files in LayoutTests/fast/dom (Closed)

Created:
4 years, 8 months ago by Srirama
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove superfluous "*-expected.txt" files in LayoutTests/fast/dom There are "*-expected.txt" files for some of the testharness.js based tests in LayoutTests/fast/dom folder. Removing these files as they are not necessary. Committed: https://crrev.com/dd09ef5da6607c16454f367bb18dbcc811c23465 Cr-Commit-Position: refs/heads/master@{#388283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -75 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Document/adopt-node-with-doctype.html View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Document/adopt-node-with-doctype-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLInputElement/input-value-null.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLInputElement/input-value-null-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Node/append-child-error.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Node/append-child-error-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-basic.html View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-basic-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Range/collapsed-range-bounding-client-rect.html View 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Range/collapsed-range-bounding-client-rect-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/innerHTML-namespaces.xhtml View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/innerHTML-namespaces-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/insertAdjacentHTML-namespaces.xhtml View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/insertAdjacentHTML-namespaces-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Srirama
PTAL. Found this while working on a layout test for one of the issues. Felt ...
4 years, 8 months ago (2016-04-19 06:05:57 UTC) #6
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-19 18:32:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894103003/1
4 years, 8 months ago (2016-04-19 18:35:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 19:40:44 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd09ef5da6607c16454f367bb18dbcc811c23465
Cr-Commit-Position: refs/heads/master@{#388283}

Powered by Google App Engine
This is Rietveld 408576698