Exclude XFA-only corpus from non-xfa and roll corpus

Exclude XFA-only corpus from non-xfa and roll corpus.

Test still need modification to process input events. For now,
we just suppress anything that diffs.

Committed: https://pdfium.googlesource.com/pdfium/+/86d945b2d24edade9c7175be1c31b246f54b04ca

[Tom Sepez, 2016-04-18 23:46:49]

Description was changed from

==========
Exclude XFA-only corpus from non-xfa and roll corpus
==========

to

==========
Exclude XFA-only corpus from non-xfa and roll corpus.

Test still need modification to process input events. For now,
we just suppress anything that diffs.
==========

[Tom Sepez, 2016-04-18 23:46:50]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-18 23:47:02]

Lei, for review.

[Lei Zhang, 2016-04-18 23:57:26]

lgtm

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
File testing/tools/suppressor.py (right):

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
testing/tools/suppressor.py:15: v8_option = ["nov8", "v8"][self.has_v8]
how about the more common way to do ternary operators in Python?

v8_option = "v8" if self.has_v8 else "nov8"

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
testing/tools/suppressor.py:44: def IsExecutionSuppressed(self, input_filepath):
The difference between this and IsSuppressed() may not be obvious to readers.
Maybe IsSuppressed() should be renamed IsErrorResultSuppressed() ?

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
testing/tools/suppressor.py:45: return "xfa_specific" in input_filepath and not
self.has_xfa
Do you want to print a message to indicate suppression, like with IsSuppressed()
?

[Tom Sepez, 2016-04-19 00:04:47]

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
File testing/tools/suppressor.py (right):

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
testing/tools/suppressor.py:15: v8_option = ["nov8", "v8"][self.has_v8]
On 2016/04/18 23:57:25, Lei Zhang wrote:
> how about the more common way to do ternary operators in Python?
> 
> v8_option = "v8" if self.has_v8 else "nov8"

Done.

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
testing/tools/suppressor.py:44: def IsExecutionSuppressed(self, input_filepath):
On 2016/04/18 23:57:26, Lei Zhang wrote:
> The difference between this and IsSuppressed() may not be obvious to readers.
> Maybe IsSuppressed() should be renamed IsErrorResultSuppressed() ?

Done.

https://codereview.chromium.org/1894083003/diff/40001/testing/tools/suppresso...
testing/tools/suppressor.py:45: return "xfa_specific" in input_filepath and not
self.has_xfa
On 2016/04/18 23:57:26, Lei Zhang wrote:
> Do you want to print a message to indicate suppression, like with
IsSuppressed()
> ?

[Tom Sepez, 2016-04-19 00:15:19]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-19 00:15:20]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1894083003/#ps60001
(title: "Tidy, print suppression msg.")

[commit-bot: I haz the power, 2016-04-19 00:15:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894083003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894083003/60001

[commit-bot: I haz the power, 2016-04-19 00:15:46]

Description was changed from

==========
Exclude XFA-only corpus from non-xfa and roll corpus.

Test still need modification to process input events. For now,
we just suppress anything that diffs.
==========

to

==========
Exclude XFA-only corpus from non-xfa and roll corpus.

Test still need modification to process input events. For now,
we just suppress anything that diffs.

Committed:
https://pdfium.googlesource.com/pdfium/+/86d945b2d24edade9c7175be1c31b246f54b...
==========

[commit-bot: I haz the power, 2016-04-19 00:15:47]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/86d945b2d24edade9c7175be1c31b246f54b...