Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1894073007: [Interpreter] Fix typo in generate-bytecode-expectations. (Closed)

Created:
4 years, 8 months ago by rmcilroy
Modified:
4 years, 8 months ago
Reviewers:
neis, adamk
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix typo in generate-bytecode-expectations. BUG=v8:4681 LOG=N Committed: https://crrev.com/04927031d02ca57ab5088e2bf59b8136a7f5f38b Cr-Commit-Position: refs/heads/master@{#35679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/interpreter/generate-bytecode-expectations.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
rmcilroy
PTAL, thanks.
4 years, 8 months ago (2016-04-20 16:17:53 UTC) #2
adamk
lgtm, I was fighting this the other day (having generate-bytecode-expectations drop everything when generating expectations ...
4 years, 8 months ago (2016-04-20 20:45:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894073007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894073007/1
4 years, 8 months ago (2016-04-20 20:45:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 21:05:03 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04927031d02ca57ab5088e2bf59b8136a7f5f38b
Cr-Commit-Position: refs/heads/master@{#35679}

Powered by Google App Engine
This is Rietveld 408576698