Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

Issue 1894073006: Store Physical Web URL data in memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make final members final Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
index f51511ee8418f9b4f31f347626736a444ccab8fd..c5d28e68d75d8c8ee86dfd355264b6349ff7a14c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
@@ -156,9 +156,9 @@ public class PhysicalWebDiagnosticsPage implements NativePage {
private void appendUrlManagerReport(StringBuilder sb) {
UrlManager urlManager = UrlManager.getInstance(mContext);
- Set<UrlInfo> nearbyUrls = new HashSet<UrlInfo>(urlManager.getCachedNearbyUrls());
- Set<UrlInfo> resolvedUrls = new HashSet<UrlInfo>(urlManager.getCachedResolvedUrls());
- Set<UrlInfo> union = new HashSet<UrlInfo>(nearbyUrls);
+ Set<String> nearbyUrls = new HashSet<>(urlManager.getNearbyUrls());
+ Set<String> resolvedUrls = new HashSet<>(urlManager.getResolvedUrls());
+ Set<String> union = new HashSet<>(nearbyUrls);
union.addAll(resolvedUrls);
sb.append("<h2>Nearby web pages</h2>");
@@ -166,7 +166,7 @@ public class PhysicalWebDiagnosticsPage implements NativePage {
if (union.isEmpty()) {
sb.append("No nearby web pages found<br/>");
} else {
- for (UrlInfo url : union) {
+ for (String url : union) {
boolean isNearby = nearbyUrls.contains(url);
boolean isResolved = resolvedUrls.contains(url);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698