Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1894073002: Revert of Allow muting/unmuting audio through media track API (Closed)

Created:
4 years, 8 months ago by perkj_chrome
Modified:
4 years, 8 months ago
Reviewers:
servolk, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, xhwang, perkj_chrome
Base URL:
https://chromium.googlesource.com/chromium/src.git@blink-sb-tracks6
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow muting/unmuting audio through media track API (patchset #37 id:710001 of https://codereview.chromium.org/1812543003/ ) Reason for revert: Tentative revert since it looks like it cause flake on http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/2433 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10?numbuilds=200 Original issue's description: > Allow muting/unmuting audio through media track API > > This CL implements muting/unmuting audio via HTML5 media track APIs. > More specifically it adds basic plumbing to deliver media track state > changes from blink level to media::Renderer, by translating blink track > ids into DemuxerStream pointers in demuxer and then delivering > DemuxerStream state information to media renderers. For now audio > stream is disabled by setting volume to 0, but this can be done more > efficiently in the future. > > BUG=249427 > > Committed: https://crrev.com/06e3a9ffca065ed73c1cd9e5d72f7ca2ee44f488 > Cr-Commit-Position: refs/heads/master@{#387789} TBR=wolenetz@chromium.org,servolk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=249427 Committed: https://chromium.googlesource.com/chromium/src/+/515ae317c22aafa3d6551ddf6871cc042050be6c

Patch Set 1 #

Patch Set 2 : git cl format media #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -504 lines) Patch
M media/base/demuxer.h View 1 2 chunks +1 line, -13 lines 0 comments Download
M media/base/media_tracks.h View 1 2 chunks +10 lines, -31 lines 0 comments Download
M media/base/media_tracks.cc View 1 1 chunk +10 lines, -46 lines 0 comments Download
M media/base/mock_filters.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M media/base/pipeline.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M media/base/pipeline_impl.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/pipeline_impl.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M media/base/renderer.h View 1 3 chunks +0 lines, -19 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 5 chunks +2 lines, -45 lines 0 comments Download
M media/blink/websourcebuffer_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 4 chunks +2 lines, -14 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 3 chunks +9 lines, -34 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 5 chunks +0 lines, -26 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 4 chunks +0 lines, -13 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 chunks +4 lines, -19 lines 0 comments Download
M media/filters/media_source_state.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/media_source_state.cc View 1 5 chunks +7 lines, -34 lines 0 comments Download
M media/renderers/renderer_impl.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M media/renderers/renderer_impl.cc View 1 2 chunks +2 lines, -56 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 5 chunks +7 lines, -75 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 1 2 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
perkj_chrome
Created Revert of Allow muting/unmuting audio through media track API
4 years, 8 months ago (2016-04-18 09:37:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894073002/1
4 years, 8 months ago (2016-04-18 09:37:11 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/169733)
4 years, 8 months ago (2016-04-18 09:44:07 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/515ae317c22aafa3d6551ddf6871cc042050be6c Cr-Commit-Position: refs/heads/master@{#387883}
4 years, 8 months ago (2016-04-18 10:31:53 UTC) #8
perkj_chrome
4 years, 8 months ago (2016-04-18 10:32:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:320001) manually as
515ae317c22aafa3d6551ddf6871cc042050be6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698