Issue 1894043002: Enable UpdateProcessPriority() on startup on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1894043002: Enable UpdateProcessPriority() on startup on Chrome OS. (Closed)

Created:
4 years, 8 months ago by jcliang

Modified:
4 years, 1 month ago

Reviewers:
rjkroege, gab

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enable UpdateProcessPriority() on startup on Chrome OS. BUG=601023 Signed-off-by: Ricky Liang <jcliang@chromium.org>;

Patch Set 1 #

Total comments: 1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

gab

Will block this review on resolution of discussion @ https://crbug.com/601023#c7

4 years, 8 months ago (2016-04-18 15:51:32 UTC) #3

rjkroege

4 years, 8 months ago (2016-04-18 17:06:07 UTC) #4

https://codereview.chromium.org/1894043002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/1894043002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:2616: #if
defined(OS_ANDROID) || defined(OS_CHROMEOS)
I am not convinced that this is the right place for this functionality
especially as we mojo-i-fy CrOS chrome.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages