Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 189403002: QUIC - Minor cleanup changes to match the internal source code. (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

QUIC - Minor cleanup changes to match the internal source code. + Added using statements. + Deleted annonmous namespace and include order in congest_control area to match internal source code. R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255632

Patch Set 1 #

Total comments: 2

Patch Set 2 : use public ::testing:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M net/quic/congestion_control/paced_sender.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_config.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_config.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
ramant (doing other things)
6 years, 9 months ago (2014-03-06 23:17:39 UTC) #1
Ryan Hamilton
lgtm, modulo one nit https://codereview.chromium.org/189403002/diff/1/net/quic/quic_config_test.cc File net/quic/quic_config_test.cc (right): https://codereview.chromium.org/189403002/diff/1/net/quic/quic_config_test.cc#newcode22 net/quic/quic_config_test.cc:22: class QuicConfigTest : public testing::Test ...
6 years, 9 months ago (2014-03-06 23:42:51 UTC) #2
ramant (doing other things)
https://codereview.chromium.org/189403002/diff/1/net/quic/quic_config_test.cc File net/quic/quic_config_test.cc (right): https://codereview.chromium.org/189403002/diff/1/net/quic/quic_config_test.cc#newcode22 net/quic/quic_config_test.cc:22: class QuicConfigTest : public testing::Test { On 2014/03/06 23:42:51, ...
6 years, 9 months ago (2014-03-06 23:54:06 UTC) #3
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-07 02:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/189403002/40001
6 years, 9 months ago (2014-03-07 02:47:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 05:23:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-07 05:23:58 UTC) #7
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-07 06:14:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/189403002/40001
6 years, 9 months ago (2014-03-07 06:15:22 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 06:53:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 06:53:12 UTC) #11
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-07 14:55:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/189403002/40001
6 years, 9 months ago (2014-03-07 14:55:41 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 16:19:18 UTC) #14
Message was sent while issue was closed.
Change committed as 255632

Powered by Google App Engine
This is Rietveld 408576698