third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 1893983002: Simplify handling of Transferable objects while (de)serializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1893983002: Simplify handling of Transferable objects while (de)serializing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove Transferable.cpp, not needed after all. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 3a6e5fc3bb78671188b4430b1b974c821a37f730..fe584f144b44407b1dc08cddf14aab0ff8269082 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -842,7 +842,8 @@ TEST_P(ParameterizedWebFrameTest, PostMessageThenDetach)

LocalFrame* frame = toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame());

NonThrowableExceptionState exceptionState;

- frame->domWindow()->postMessage(SerializedScriptValueFactory::instance().create("message"), 0, "*", frame->localDOMWindow(), exceptionState);

+ MessagePortArray messagePorts;

+ frame->domWindow()->postMessage(SerializedScriptValueFactory::instance().create("message"), messagePorts, "*", frame->localDOMWindow(), exceptionState);

webViewHelper.reset();

EXPECT_FALSE(exceptionState.hadException());

« third_party/WebKit/Source/core/dom/MessagePort.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp ('k') | no next file » | no next file with comments »