third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp - Issue 1893983002: Simplify handling of Transferable objects while (de)serializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

Issue 1893983002: Simplify handling of Transferable objects while (de)serializing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove Transferable.cpp, not needed after all. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/MessagePort.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

index 8c1a97138eb3ccf68f4ac34cb97dcfe5cd71df16..aa39db2a03a437a3fcfaff34919003aee963037c 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

@@ -49,7 +49,7 @@ const AtomicString& ServiceWorker::interfaceName() const

return EventTargetNames::ServiceWorker;

}

-void ServiceWorker::postMessage(ExecutionContext* context, PassRefPtr<SerializedScriptValue> message, const MessagePortArray* ports, ExceptionState& exceptionState)

+void ServiceWorker::postMessage(ExecutionContext* context, PassRefPtr<SerializedScriptValue> message, const MessagePortArray& ports, ExceptionState& exceptionState)

{

ServiceWorkerContainerClient* client = ServiceWorkerContainerClient::from(getExecutionContext());

if (!client || !client->provider()) {