third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h - Issue 1893983002: Simplify handling of Transferable objects while (de)serializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

Issue 1893983002: Simplify handling of Transferable objects while (de)serializing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove Transferable.cpp, not needed after all. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/Transferables.h ('K') | « third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp » ('j') | third_party/WebKit/Source/core/dom/MessagePort.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

diff --git a/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h b/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

index a3754e4ffe9fdbab74539e1eceee732368adcb31..b133793e484c030686d9dfcd6952ffca0a7397bc 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

+++ b/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

@@ -16,11 +16,11 @@ class SerializedScriptValueForModulesFactory final : public SerializedScriptValu

public:

SerializedScriptValueForModulesFactory() : SerializedScriptValueFactory() { }

- PassRefPtr<SerializedScriptValue> create(v8::Isolate*, v8::Local<v8::Value>, TransferableArray*, WebBlobInfoArray*, ExceptionState&) override;

+ PassRefPtr<SerializedScriptValue> create(v8::Isolate*, v8::Local<v8::Value>, Transferables*, WebBlobInfoArray*, ExceptionState&) override;

PassRefPtr<SerializedScriptValue> create(v8::Isolate*, const String&) override;

protected:

- ScriptValueSerializer::Status doSerialize(v8::Local<v8::Value>, SerializedScriptValueWriter&, TransferableArray*, WebBlobInfoArray*, BlobDataHandleMap&, v8::TryCatch&, String& errorMessage, v8::Isolate*) override;

+ ScriptValueSerializer::Status doSerialize(v8::Local<v8::Value>, SerializedScriptValueWriter&, Transferables*, WebBlobInfoArray*, BlobDataHandleMap&, v8::TryCatch&, String& errorMessage, v8::Isolate*) override;

v8::Local<v8::Value> deserialize(String& data, BlobDataHandleMap& blobDataHandles, ArrayBufferContentsArray*, ImageBitmapContentsArray*, v8::Isolate*, MessagePortArray* messagePorts, const WebBlobInfoArray*) override;

};