third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h - Issue 1893983002: Simplify handling of Transferable objects while (de)serializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

Issue 1893983002: Simplify handling of Transferable objects while (de)serializing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove Transferable.cpp, not needed after all. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/Transferables.h ('K') | « third_party/WebKit/Source/bindings/core/v8/v8.gypi ('k') | third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp » ('j') | third_party/WebKit/Source/core/dom/MessagePort.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

diff --git a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

index 81719052420a057c9fdfe1b7440463c194859625..4d929db5688ded0556dfdebc382dae9935d616f5 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

+++ b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

@@ -70,7 +70,7 @@ class ScriptValueSerializerForModules final : public ScriptValueSerializer {

STACK_ALLOCATED();

WTF_MAKE_NONCOPYABLE(ScriptValueSerializerForModules);

public:

- ScriptValueSerializerForModules(SerializedScriptValueWriter&, TransferableArray* transferables, WebBlobInfoArray*, BlobDataHandleMap& blobDataHandles, v8::TryCatch&, ScriptState*);

+ ScriptValueSerializerForModules(SerializedScriptValueWriter&, const Transferables*, WebBlobInfoArray*, BlobDataHandleMap&, v8::TryCatch&, ScriptState*);

private:

ScriptValueSerializer::StateBase* doSerializeValue(v8::Local<v8::Value>, ScriptValueSerializer::StateBase* next) override;