third_party/WebKit/Source/bindings/core/v8/Transferables.cpp - Issue 1893983002: Simplify handling of Transferable objects while (de)serializing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/Transferables.cpp

Issue 1893983002: Simplify handling of Transferable objects while (de)serializing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/Transferables.h ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "bindings/core/v8/Transferables.h"

	6

	7 #include "core/dom/DOMArrayBufferBase.h"

	8 #include "core/dom/MessagePort.h"

	9 #include "core/frame/ImageBitmap.h"

	10

	11 namespace blink {

	12

	13 Transferables::Transferables()
	haraken 2016/04/17 23:57:22 Nit: Maybe we can inline these constructors/destru Nit: Maybe we can inline these constructors/destructors. sof 2016/04/18 06:41:56 Yes, that works out -- MSVC gave me some trouble, Show quoted text On 2016/04/17 23:57:22, haraken wrote: > > Nit: Maybe we can inline these constructors/destructors. Yes, that works out -- MSVC gave me some trouble, which is what prompted out-of-lining them. But that turns out to be due to the copy constructor that it is more eager about instantiating/generating. iow, done - removed Transferables.cpp
	14 {

	15 }

	16

	17 Transferables::~Transferables()

	18 {

	19 }

	20

	21 } // namespace blink

OLD	NEW