Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1893943002: X87: [generators] Store the resume mode in the generator object. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
Reviewers:
Weiliang, chunyang.dai, neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [generators] Store the resume mode in the generator object. port 2e3296666b04f0a038d9239a92e2ff39b5716f74(r35370) original commit message: ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. BUG= Committed: https://crrev.com/807049584d4a019d978d09f604b8ae9c900964f6 Cr-Commit-Position: refs/heads/master@{#35555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/x87/builtins-x87.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-17 15:30:02 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-17 16:01:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893943002/1
4 years, 8 months ago (2016-04-18 02:12:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 02:29:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 02:30:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/807049584d4a019d978d09f604b8ae9c900964f6
Cr-Commit-Position: refs/heads/master@{#35555}

Powered by Google App Engine
This is Rietveld 408576698