Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1893933002: gn: Use .obj extension for pch objects on Windows. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Use .obj extension for pch objects on Windows. Fixes a cosmetic regression from https://codereview.chromium.org/1292983004 BUG=603902 Committed: https://crrev.com/c065bd83a55626de81db52aca9bf88dbb425e904 Cr-Commit-Position: refs/heads/master@{#387893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M tools/gn/ninja_binary_target_writer.cc View 4 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 8 months ago (2016-04-17 04:48:42 UTC) #2
brettw
lgtm
4 years, 8 months ago (2016-04-18 05:26:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893933002/1
4 years, 8 months ago (2016-04-18 11:29:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 12:07:59 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 12:09:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c065bd83a55626de81db52aca9bf88dbb425e904
Cr-Commit-Position: refs/heads/master@{#387893}

Powered by Google App Engine
This is Rietveld 408576698