Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 189393003: Create blink_headers target for header-only dependencies (Closed)

Created:
6 years, 9 months ago by jamesr
Modified:
6 years, 9 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Create blink_headers target for header-only dependencies Some code in Chromium wants to use Blink's public API headers for the definitions of types, enums, structs etc without actually linking against the Blink library itself. This target sets up the build configuration so that relative include paths in the Blink headers resolve correctly. Once Chromium targets are updated to reflect their dependencies more accurately, we can get rid of the relative includes in the public Blink API. BUG=350097 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M public/blink.gyp View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
6 years, 9 months ago (2014-03-07 01:09:18 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-07 01:29:32 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 9 months ago (2014-03-07 01:30:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/189393003/1
6 years, 9 months ago (2014-03-07 01:30:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 02:30:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-07 02:30:58 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-07 05:27:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/189393003/1
6 years, 9 months ago (2014-03-07 05:27:54 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 06:47:52 UTC) #9
Message was sent while issue was closed.
Change committed as 168709

Powered by Google App Engine
This is Rietveld 408576698