net: Update FileStream to use base::File instead of PlatformFile.

net/base/file_stream_context_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/file_stream_context.h"
 
 #include <windows.h>
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
@@ skipping 22 matching lines @@
   offset.HighPart = overlapped->OffsetHigh;
   offset.QuadPart += static_cast<LONGLONG>(count);
   SetOffset(overlapped, offset);
 }
 
 }  // namespace
 
 FileStream::Context::Context(const BoundNetLog& bound_net_log,
                              const scoped_refptr<base::TaskRunner>& task_runner)
     : io_context_(),
-      file_(base::kInvalidPlatformFileValue),
       record_uma_(false),
       async_in_progress_(false),
       orphaned_(false),
+      async_(false),
       bound_net_log_(bound_net_log),
       error_source_(FILE_ERROR_SOURCE_COUNT),
       task_runner_(task_runner) {
   io_context_.handler = this;
   memset(&io_context_.overlapped, 0, sizeof(io_context_.overlapped));
 }
 
-FileStream::Context::Context(base::PlatformFile file,
+FileStream::Context::Context(base::File file,
                              const BoundNetLog& bound_net_log,
-                             int open_flags,
                              const scoped_refptr<base::TaskRunner>& task_runner)
     : io_context_(),
-      file_(file),
+      file_(file.Pass()),
       record_uma_(false),
       async_in_progress_(false),
       orphaned_(false),
+      async_(false),
       bound_net_log_(bound_net_log),
       error_source_(FILE_ERROR_SOURCE_COUNT),
       task_runner_(task_runner) {
   io_context_.handler = this;
   memset(&io_context_.overlapped, 0, sizeof(io_context_.overlapped));
-  if (file_ != base::kInvalidPlatformFileValue &&
-      (open_flags & base::PLATFORM_FILE_ASYNC)) {
+  if (file_.IsValid() && file_.async())
     OnAsyncFileOpened();
-  }
+}
+
+FileStream::Context::Context(base::File file,
+                             int flags,
+                             const BoundNetLog& bound_net_log,
+                             const scoped_refptr<base::TaskRunner>& task_runner)
+    : io_context_(),
+      file_(file.Pass()),
+      record_uma_(false),
+      async_in_progress_(false),
+      orphaned_(false),
+      async_((flags & base::File::FLAG_ASYNC) == base::File::FLAG_ASYNC),
+      bound_net_log_(bound_net_log),
+      error_source_(FILE_ERROR_SOURCE_COUNT),
+      task_runner_(task_runner) {
+  io_context_.handler = this;
+  memset(&io_context_.overlapped, 0, sizeof(io_context_.overlapped));
+  if (file_.IsValid() && (file_.async() || flags & base::File::FLAG_ASYNC))
+    OnAsyncFileOpened();
 }
 
 FileStream::Context::~Context() {
 }
 
 int64 FileStream::Context::GetFileSize() const {
   LARGE_INTEGER file_size;
-  if (!GetFileSizeEx(file_, &file_size)) {
+  if (!GetFileSizeEx(file_.GetPlatformFile(), &file_size)) {
     IOResult error = IOResult::FromOSError(GetLastError());
     LOG(WARNING) << "GetFileSizeEx failed: " << error.os_error;
     RecordError(error, FILE_ERROR_SOURCE_GET_SIZE);
     return error.result;
   }
 
   return file_size.QuadPart;
 }
 
 int FileStream::Context::ReadAsync(IOBuffer* buf,
                                    int buf_len,
                                    const CompletionCallback& callback) {
   DCHECK(!async_in_progress_);
   error_source_ = FILE_ERROR_SOURCE_READ;
 
   DWORD bytes_read;
-  if (!ReadFile(file_, buf->data(), buf_len,
+  if (!ReadFile(file_.GetPlatformFile(), buf->data(), buf_len,
                 &bytes_read, &io_context_.overlapped)) {
     IOResult error = IOResult::FromOSError(GetLastError());
     if (error.os_error == ERROR_IO_PENDING) {
       IOCompletionIsPending(callback, buf);
     } else if (error.os_error == ERROR_HANDLE_EOF) {
       return 0;  // Report EOF by returning 0 bytes read.
     } else {
       LOG(WARNING) << "ReadFile failed: " << error.os_error;
       RecordError(error, FILE_ERROR_SOURCE_READ);
     }
     return error.result;
   }
 
   IOCompletionIsPending(callback, buf);
   return ERR_IO_PENDING;
 }
 
 int FileStream::Context::ReadSync(char* buf, int buf_len) {
   DWORD bytes_read;
-  if (!ReadFile(file_, buf, buf_len, &bytes_read, NULL)) {
+  if (!ReadFile(file_.GetPlatformFile(), buf, buf_len, &bytes_read, NULL)) {
     IOResult error = IOResult::FromOSError(GetLastError());
     if (error.os_error == ERROR_HANDLE_EOF) {
       return 0;  // Report EOF by returning 0 bytes read.
     } else {
       LOG(WARNING) << "ReadFile failed: " << error.os_error;
       RecordError(error, FILE_ERROR_SOURCE_READ);
     }
     return error.result;
   }
 
   return bytes_read;
 }
 
 int FileStream::Context::WriteAsync(IOBuffer* buf,
                                     int buf_len,
                                     const CompletionCallback& callback) {
   error_source_ = FILE_ERROR_SOURCE_WRITE;
 
   DWORD bytes_written = 0;
-  if (!WriteFile(file_, buf->data(), buf_len,
+  if (!WriteFile(file_.GetPlatformFile(), buf->data(), buf_len,
                  &bytes_written, &io_context_.overlapped)) {
     IOResult error = IOResult::FromOSError(GetLastError());
     if (error.os_error == ERROR_IO_PENDING) {
       IOCompletionIsPending(callback, buf);
     } else {
       LOG(WARNING) << "WriteFile failed: " << error.os_error;
       RecordError(error, FILE_ERROR_SOURCE_WRITE);
     }
     return error.result;
   }
 
   IOCompletionIsPending(callback, buf);
   return ERR_IO_PENDING;
 }
 
 int FileStream::Context::WriteSync(const char* buf, int buf_len) {
   DWORD bytes_written = 0;
-  if (!WriteFile(file_, buf, buf_len, &bytes_written, NULL)) {
+  if (!WriteFile(file_.GetPlatformFile(), buf, buf_len, &bytes_written, NULL)) {
     IOResult error = IOResult::FromOSError(GetLastError());
     LOG(WARNING) << "WriteFile failed: " << error.os_error;
     RecordError(error, FILE_ERROR_SOURCE_WRITE);
     return error.result;
   }
 
   return bytes_written;
 }
 
 int FileStream::Context::Truncate(int64 bytes) {
-  if (!SetEndOfFile(file_)) {
+  if (!SetEndOfFile(file_.GetPlatformFile())) {
     IOResult error = IOResult::FromOSError(GetLastError());
     LOG(WARNING) << "SetEndOfFile failed: " << error.os_error;
     RecordError(error, FILE_ERROR_SOURCE_SET_EOF);
     return error.result;
   }
 
   return bytes;
 }
 
 void FileStream::Context::OnAsyncFileOpened() {
-  base::MessageLoopForIO::current()->RegisterIOHandler(file_, this);
+  base::MessageLoopForIO::current()->RegisterIOHandler(file_.GetPlatformFile(),
+                                                       this);
 }
 
 FileStream::Context::IOResult FileStream::Context::SeekFileImpl(Whence whence,
                                                                 int64 offset) {
   LARGE_INTEGER distance, res;
   distance.QuadPart = offset;
   DWORD move_method = static_cast<DWORD>(whence);
-  if (SetFilePointerEx(file_, distance, &res, move_method)) {
+  if (SetFilePointerEx(file_.GetPlatformFile(), distance, &res, move_method)) {
     SetOffset(&io_context_.overlapped, res);
     return IOResult(res.QuadPart, 0);
   }
 
   return IOResult::FromOSError(GetLastError());
 }
 
 FileStream::Context::IOResult FileStream::Context::FlushFileImpl() {
-  if (FlushFileBuffers(file_))
+  if (FlushFileBuffers(file_.GetPlatformFile()))
     return IOResult(OK, 0);
 
   return IOResult::FromOSError(GetLastError());
-}
-
-FileStream::Context::IOResult FileStream::Context::CloseFileImpl() {
-  bool success = base::ClosePlatformFile(file_);
-  file_ = base::kInvalidPlatformFileValue;
-  if (success)
-    return IOResult(OK, 0);
-
-  return IOResult::FromOSError(GetLastError());
 }
 
 void FileStream::Context::IOCompletionIsPending(
     const CompletionCallback& callback,
     IOBuffer* buf) {
   DCHECK(callback_.is_null());
   callback_ = callback;
   in_flight_buf_ = buf;  // Hold until the async operation ends.
   async_in_progress_ = true;
 }
@@ skipping 27 matching lines @@
   }
 
   CompletionCallback temp_callback = callback_;
   callback_.Reset();
   scoped_refptr<IOBuffer> temp_buf = in_flight_buf_;
   in_flight_buf_ = NULL;
   temp_callback.Run(result);
 }
 
 }  // namespace net