Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1893893002: Revert of [turbofan] Remove the leftover LoadBuffer hacks. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Remove the leftover LoadBuffer hacks. (patchset #1 id:1 of https://codereview.chromium.org/1887343002/ ) Reason for revert: Using types in ChangeLowering is generally unsafe. Original issue's description: > [turbofan] Remove the leftover LoadBuffer hacks. > > R=jarin@chromium.org > > Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 > Cr-Commit-Position: refs/heads/master@{#35509} TBR=jarin@chromium.org,mstarzinger@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/0b9cd6cbec8a5420ca7bf11b1b8c078d31e96827 Cr-Commit-Position: refs/heads/master@{#35549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
Created Revert of [turbofan] Remove the leftover LoadBuffer hacks.
4 years, 8 months ago (2016-04-16 18:35:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893893002/1
4 years, 8 months ago (2016-04-16 18:35:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 18:57:06 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 18:58:26 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b9cd6cbec8a5420ca7bf11b1b8c078d31e96827
Cr-Commit-Position: refs/heads/master@{#35549}

Powered by Google App Engine
This is Rietveld 408576698