Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1893853002: Use unique_ptr in more parts of mus code (Closed)

Created:
4 years, 8 months ago by rjkroege
Modified:
4 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unique_ptr in more parts of mus code BUG=none Committed: https://crrev.com/e40b6ff302d21447f4c75628047128e9fde15ad9 Cr-Commit-Position: refs/heads/master@{#387804}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M components/mus/surfaces/direct_output_surface.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/mus/surfaces/surfaces_context_provider.h View 2 chunks +5 lines, -4 lines 0 comments Download
M components/mus/surfaces/surfaces_state.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rjkroege
ptal
4 years, 8 months ago (2016-04-16 02:01:01 UTC) #2
danakj
LGTM https://codereview.chromium.org/1893853002/diff/1/components/mus/surfaces/surfaces_state.h File components/mus/surfaces/surfaces_state.h (right): https://codereview.chromium.org/1893853002/diff/1/components/mus/surfaces/surfaces_state.h#newcode10 components/mus/surfaces/surfaces_state.h:10: #include <memory> looks unused in this file
4 years, 8 months ago (2016-04-16 02:03:55 UTC) #3
rjkroege
https://codereview.chromium.org/1893853002/diff/1/components/mus/surfaces/surfaces_state.h File components/mus/surfaces/surfaces_state.h (right): https://codereview.chromium.org/1893853002/diff/1/components/mus/surfaces/surfaces_state.h#newcode10 components/mus/surfaces/surfaces_state.h:10: #include <memory> On 2016/04/16 02:03:55, danakj wrote: > looks ...
4 years, 8 months ago (2016-04-16 02:17:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893853002/20001
4 years, 8 months ago (2016-04-16 02:17:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-16 02:58:23 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 02:59:54 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e40b6ff302d21447f4c75628047128e9fde15ad9
Cr-Commit-Position: refs/heads/master@{#387804}

Powered by Google App Engine
This is Rietveld 408576698