Fix mini_installer archive paths with gn

Fix mini_installer archive paths with gn

Due to a subtlety of 7za's behavior the file paths in the mini_installer
archive were incorrect in gn builds. This is a trivial change to make
them behave the same as in gyp builds.

BUG=601132
Committed: https://crrev.com/2d7f454406379fbf4e9221ff5328f4d364d754ca
Cr-Commit-Position: refs/heads/master@{#387939}

[brucedawson, 2016-04-16 00:35:56]

brucedawson@chromium.org changed reviewers:
+ gab@chromium.org

[brucedawson, 2016-04-16 00:35:57]

It took a while to figure out what the difference was between gyp and gn. It
turned out the only difference was the current directory, and therefore the
relative path to the temp_installer_archive directory.

The fix is trivial, with a block comment to explain why.

With this change when I run mini_installer it launches my locally built chrome
from c:\Users\brucedawson\AppData\Local\Chromium\Application.

[gab, 2016-04-18 15:44:56]

Description was changed from

==========
Fix mini_installer archive paths with gn

Due to a subtlety of 7za's behavior the file paths in the mini_installer
archive were incorrect in gn builds. This is a trivial change to make
them behave the same as in gyp builds.

BUG=601132
==========

to

==========
Fix mini_installer archive paths with gn

Due to a subtlety of 7za's behavior the file paths in the mini_installer
archive were incorrect in gn builds. This is a trivial change to make
them behave the same as in gyp builds.

BUG=601132
==========

[gab, 2016-04-18 15:45:55]

On 2016/04/16 00:35:57, brucedawson wrote:
> It took a while to figure out what the difference was between gyp and gn. It
> turned out the only difference was the current directory, and therefore the
> relative path to the temp_installer_archive directory.
> 
> The fix is trivial, with a block comment to explain why.
> 
> With this change when I run mini_installer it launches my locally built chrome
> from c:\Users\brucedawson\AppData\Local\Chromium\Application.

Thanks for figuring this out. lgtm if it works :-)

CC grt FYI (the only other place I could find that uses 7za.exe is the
alternate_version_generator [1], not sure if it's susceptible to this bug)

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/t...

[brucedawson, 2016-04-18 16:48:24]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-04-18 16:48:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893823002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893823002/1

[commit-bot: I haz the power, 2016-04-18 17:28:03]

Description was changed from

==========
Fix mini_installer archive paths with gn

Due to a subtlety of 7za's behavior the file paths in the mini_installer
archive were incorrect in gn builds. This is a trivial change to make
them behave the same as in gyp builds.

BUG=601132
==========

to

==========
Fix mini_installer archive paths with gn

Due to a subtlety of 7za's behavior the file paths in the mini_installer
archive were incorrect in gn builds. This is a trivial change to make
them behave the same as in gyp builds.

BUG=601132
==========

[commit-bot: I haz the power, 2016-04-18 17:28:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-18 17:30:14]

Description was changed from

==========
Fix mini_installer archive paths with gn

Due to a subtlety of 7za's behavior the file paths in the mini_installer
archive were incorrect in gn builds. This is a trivial change to make
them behave the same as in gyp builds.

BUG=601132
==========

to

==========
Fix mini_installer archive paths with gn

Due to a subtlety of 7za's behavior the file paths in the mini_installer
archive were incorrect in gn builds. This is a trivial change to make
them behave the same as in gyp builds.

BUG=601132

Committed: https://crrev.com/2d7f454406379fbf4e9221ff5328f4d364d754ca
Cr-Commit-Position: refs/heads/master@{#387939}
==========

[commit-bot: I haz the power, 2016-04-18 17:30:15]

Patchset 1 (id:??) landed as
https://crrev.com/2d7f454406379fbf4e9221ff5328f4d364d754ca
Cr-Commit-Position: refs/heads/master@{#387939}

[Dirk Pranke, 2016-06-25 22:53:46]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org