Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1893803002: QUIC - Fix a type casting bug in quic stream sequencer buffer. (Closed)

Created:
4 years, 8 months ago by Buck
Modified:
4 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, tinazh
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

QUIC - Fix a type casting bug in quic stream sequencer buffer. This change is manually created against branch 2661 (M50) for post release merge. Without this change, a QUIC frame with offset higher than 2^32 might corrupt StreamSequencerBuffer's missing frame recording logic in a 32-bit machine. Merge internal change: 117245736 BUG=603656 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M net/quic/stream_sequencer_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/stream_sequencer_buffer_test.cc View 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Buck
4 years, 8 months ago (2016-04-16 00:10:49 UTC) #3
Buck
On 2016/04/16 00:10:49, Buck wrote: FYI, I followed the following procedure to create this CL: ...
4 years, 8 months ago (2016-04-16 00:14:21 UTC) #4
Ryan Hamilton
lgtm
4 years, 8 months ago (2016-04-16 14:51:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893803002/1
4 years, 8 months ago (2016-04-18 21:20:38 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-18 21:20:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893803002/1
4 years, 8 months ago (2016-04-18 21:24:24 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:25:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698