Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: base/test/multiprocess_test_android.cc

Issue 189373002: Add multiprocess test helper functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: restore old MakeCmdLine behavior Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/multiprocess_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/multiprocess_test_android.cc
diff --git a/base/test/multiprocess_test_android.cc b/base/test/multiprocess_test_android.cc
index c518bb438ac87e652ec38b20aac66288b7b5dcdc..8a85cdf71e76e6993c154da8b074c4e38565184c 100644
--- a/base/test/multiprocess_test_android.cc
+++ b/base/test/multiprocess_test_android.cc
@@ -15,14 +15,15 @@ namespace base {
// A very basic implementation for Android. On Android tests can run in an APK
// and we don't have an executable to exec*. This implementation does the bare
// minimum to execute the method specified by procname (in the child process).
+// - |base_command_line| is ignored.
// - All options except |fds_to_remap| are ignored.
// - |debug_on_start| is ignored.
-ProcessHandle MultiProcessTest::SpawnChildWithOptions(
- const std::string& procname,
- const LaunchOptions& options,
- bool debug_on_start) {
- // TODO(vtl): The FD-remapping done below is wrong in the presence of cycles
- // (e.g., fd1 -> fd2, fd2 -> fd1). crbug.com/326576
+ProcessHandle SpawnMultiProcessTestChild(const std::string& procname,
+ const CommandLine& base_command_line,
+ const LaunchOptions& options,
+ bool debug_on_start) {
+ // TODO(viettrungluu): The FD-remapping done below is wrong in the presence of
+ // cycles (e.g., fd1 -> fd2, fd2 -> fd1). crbug.com/326576
FileHandleMappingVector empty;
const FileHandleMappingVector* fds_to_remap =
options.fds_to_remap ? options.fds_to_remap : ∅
« no previous file with comments | « base/test/multiprocess_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698